Perform file downloads with netstack in the WG gateway probe #1329
Conversation
durch
changed the title
durch
requested review from
pronebird,
tommyv1987,
benedettadavico and
mmsinclair
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benedettadavico, @mmsinclair, and @tommyv1987)
nym-vpn-core/crates/nym-gateway-probe/src/lib.rs line 221 at r1 (raw file):
wg_outcome.can_register = true; if wg_outcome.can_register {
FYI this check seems irrelevant given that you wg_outcome.can_register = true just above but maybe there is a reason for that.
nym-vpn-core/crates/nym-gateway-probe/src/lib.rs line 238 at r1 (raw file):
netstack_response.received_hosts as f32 / netstack_response.sent_hosts as f32; wg_outcome.ping_ips_performance = netstack_response.received_ips as f32 / netstack_response.sent_ips as f32;
FYI you might be ok with NaN so maybe no need to check for division by zero?
|
Clippy issue should go away if you rebase your branch. We've already fixed that in |
|
@durch bump |
|
@durch I think you should incorporate these changes in to this branch... main...tommy-test as this has all the latest probing information |
This change is